This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Install hassh and ja3 Zeek packages #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
I've tested out the PR artifacts on Windows, macOS, and Ubuntu and witnessed the JA3 and HASSH fields being populated as expected on the respective Zeek events for ssl and ssh, so this appears functionally 👍 . The script code also looks fine to me, and I pinged @alfred-landrum on Slack and he also gave it a quick look and gave his 👍 , so I'm going to click Merge on this one and prep Brim to point at it.
Thanks @nwt!
This was referenced Jun 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #11.